Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up and optimize PR builds #17811

Merged
merged 7 commits into from
Jul 24, 2023
Merged

Clean up and optimize PR builds #17811

merged 7 commits into from
Jul 24, 2023

Conversation

Xenorith
Copy link
Contributor

@Xenorith Xenorith commented Jul 20, 2023 •
edited
Loading

  • don't allow any var args in the entrypoing scripts; specify all configurations via env vars
  • specify which projects to build via ALLUXIO_DOCKER_MVN_PROJECT_LIST, add -am flag to build dependent projects
  • specify test prefix via ALLUXIO_DOCKER_MVN_TESTS
  • remove ALLUXIO_DOCKER_MVN_RUNTOEND
  • remove "libfuse version = 2" permutation from fuse integration tests
    • can't pass in an env var that contains a =, which was attempted in the format of ADDITIONAL_ARGS=property=key and caused parsing failure
  • combine several integration test permutations to reduce overall time spent, since the permutations are finishing much faster than the slowest builds = unit test and checkstyle builds

@alluxio-bot
Copy link
Contributor

Automated checks report:

  • PR title follows the conventions: FAIL
    • The title of the PR does not pass all the checks. Please fix the following issues:
      • Supported title prefixes are: [WIP], [SMALLFIX], [DOCFIX]
  • Commits associated with Github account: PASS

Some checks failed. Please fix the reported issues and reply 'alluxio-bot, check this please' to re-run checks.

@Xenorith Xenorith force-pushed the debugWebuiBuildWithoutUser branch 4 times, most recently from dfb4104 to bdcf7ea Compare July 20, 2023 21:55
@Xenorith
Clean up maven arguments in PR builds
ea6c1e5 
- don't allow any var args; specify all configurations via env vars
- specify which projects to build via ALLUXIO_DOCKER_MVN_PROJECT_LIST, add -am flag to build dependent projects
- specify test prefix via ALLUXIO_DOCKER_MVN_TESTS
- remove ALLUXIO_DOCKER_MVN_RUNTOEND
- specify ALLUXIO_DOCKER_ID=0 for builds skipping webui module, in preparation for integrating with testcontainers
  - testcontainers must run as root to access docker, webui must run as specified user to download node_modules
@Xenorith Xenorith changed the title [TEST PR] Debug webui build without user Clean up handling of maven arguments in PR builds Jul 20, 2023
@alluxio-bot
Copy link
Contributor

Automated checks report:

  • PR title follows the conventions: PASS
  • Commits associated with Github account: PASS

All checks passed!

@Xenorith Xenorith changed the title Clean up handling of maven arguments in PR builds Clean up and optimize PR builds Jul 21, 2023
@Xenorith Xenorith marked this pull request as ready for review July 21, 2023 23:31
@Xenorith Xenorith added the type-devops Build, deploy, and maintain devops questions label Jul 24, 2023
@Xenorith
Copy link
Contributor Author

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit 3f67181 into Alluxio:main Jul 24, 2023
11 checks passed
@Xenorith Xenorith mentioned this pull request Jul 26, 2023
Merged
alluxio-bot pushed a commit that referenced this pull request Jul 27, 2023
@Xenorith
Fix compilation for unit tests build
f8d61a8 
this build is failing the compilation step, claiming it can't find dora/tests jar when building dora/microbench. strange that it wasn't happening when validating #17811
			pr-link: #17842
			change-id: cid-d339245bb1f66d4dae2ce63fe41c7a77470c3a6e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucyge2022 lucyge2022 lucyge2022 approved these changes

@LuQQiu LuQQiu Awaiting requested review from LuQQiu

Assignees
No one assigned
Labels
type-devops Build, deploy, and maintain devops questions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xenorith @alluxio-bot @lucyge2022